feat(status-page): add per-status-page language setting for anonymous visitors #6615
+94
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… visitors Adds a language dropdown in the status page settings that allows admins to set a specific display language for anonymous visitors. When configured, anonymous visitors will see the status page in the selected language instead of their browser's default language. Fixes louislam#5836 Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=101010297
This comment was marked as spam.
This comment was marked as spam.
CommanderStorm
added
the
pr:needs review
CommanderStorm
requested changes
Jan 15, 2026
Collaborator
CommanderStorm
left a comment
CommanderStorm
left a comment
There was a problem hiding this comment.
Please don’t ping maintainers unless it’s necessary (e.g. to clarify blocking questions).
I need to set a clear boundary here: repeated or unnecessary pings slow things down rather than speed them up. PRs are reviewed in order as time allows, and excessive nudging disrupts that process.
On the PR:
- functionality looks good and works
- but some of the code needs minor cleanup before we can merge
Comment on lines
+46
to
+47
| async changeLang(lang, options = {}) { | ||
| const persist = options.persist !== false; |
Collaborator
There was a problem hiding this comment.
Please don't use single-item options as it is harder to reason about them when only used once
Suggested change
| async changeLang(lang, options = {}) { | |
| const persist = options.persist !== false; | |
| async changeLang(lang, persist = true) { |
src/pages/StatusPage.vue
Outdated
| // Apply configured language if the visitor hasn't set their own preference | ||
| if (this.config.language && !localStorage.locale) { | ||
| this.$root.setLanguage(this.config.language, { persist: false }); |
Collaborator
There was a problem hiding this comment.
Why not changeLang?
Comment on lines
+670
to
+673
| if (!("language" in this.config)) { | ||
| this.config.language = null; | ||
| } | ||
Collaborator
There was a problem hiding this comment.
why is this happening?
| data() { | ||
| return { | ||
| language: currentLocale(), | ||
| persistLanguage: true, |
Collaborator
There was a problem hiding this comment.
this is only ever written, what are you trying to do here?
| * @returns {void} | ||
| */ | ||
| export function setPageLocale() { | ||
| export function setPageLocale(locale = currentLocale()) { |
Collaborator
There was a problem hiding this comment.
this is resonably hard to read. Please change it like this instead and adjust the callsites.
This feedback also is applicable to localeDirection
Suggested change
| export function setPageLocale(locale = currentLocale()) { | |
| export function setPageLocale(locale) { |
Comment on lines
+163
to
+167
| if (typeof config.language === "string" && config.language.trim() !== "") { | ||
| statusPage.language = config.language.trim(); | ||
| } else { | ||
| statusPage.language = null; | ||
| } |
Collaborator
There was a problem hiding this comment.
I think this is the equivalent, or?
Suggested change
| if (typeof config.language === "string" && config.language.trim() !== "") { | |
| statusPage.language = config.language.trim(); | |
| } else { | |
| statusPage.language = null; | |
| } | |
| statusPage.language = config.language?.trim() || null; |
Comment on lines
+968
to
+988
| if (!("language" in this.config)) { | ||
| this.config.language = null; | ||
| } | ||
| if (this.config.icon) { | ||
| this.imgDataUrl = this.config.icon; | ||
| } | ||
| // Apply configured language if the visitor hasn't set their own preference | ||
| if (this.config.language && !localStorage.locale) { | ||
| this.$root.setLanguage(this.config.language, { persist: false }); | ||
| } | ||
| this.incident = res.data.incident; | ||
| this.maintenanceList = res.data.maintenanceList; | ||
| this.$root.publicGroupList = res.data.publicGroupList; | ||
| if (!this.config.domainNameList) { | ||
| this.config.domainNameList = []; | ||
| } | ||
Collaborator
There was a problem hiding this comment.
please explain what you added here and why.
This might have been a merge issue with master..
| "Leave blank to use status page title": "Leave blank to use status page title", | ||
| "Status Page Language": "Status Page Language", | ||
| "Use browser language": "Use browser language", | ||
| "statusPageLanguageDescription": "Set the display language for anonymous visitors to this status page", |
Collaborator
There was a problem hiding this comment.
I think we can be more explicit here what this does
Suggested change
| "statusPageLanguageDescription": "Set the display language for anonymous visitors to this status page", | |
| "statusPageLanguageDescription": "Set the display language for anonymous visitors to this status page. Logged-in users can change the language they see in their own settings.", |
CommanderStorm
added
pr:please address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
languagecolumn tostatus_pagetableFixes #5836
Changes
2026-01-06-0000-add-status-page-language.jsserver/model/status_page.jsto include language in JSON outputserver/socket-handlers/status-page-socket-handler.jsto save language settingsrc/pages/StatusPage.vuesrc/lang/en.jsonsrc/mixins/lang.jsto support non-persisted language changessrc/i18n.jsandsrc/util-frontend.jsfor status page language supportTest plan
All tests completed successfully:
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=101010297